Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pytest: 5.3.5 -> 5.4.1 #86735

Closed
wants to merge 3 commits into from

Conversation

@jonringer
Copy link
Contributor

jonringer commented May 4, 2020

Motivation for this change

attempt at #83675 again, this time giving a month for the ecosystem to adjust.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@drewrisinger
Copy link
Contributor

drewrisinger commented May 15, 2020

FYI, looks pytest was updated to 5.4.2 in the meantime. https://docs.pytest.org/en/latest/changelog.html

Copy link
Contributor

drewrisinger left a comment

Diff LGTM. Didn't build. nix-review doesn't work because of merge conflicts.

@jonringer
Copy link
Contributor Author

jonringer commented May 15, 2020

This was cherry-picked into python-unstable, then merged into staging, now in #87814

@jonringer jonringer closed this May 15, 2020
@jonringer
Copy link
Contributor Author

jonringer commented May 15, 2020

the conflicts were because staging is now at 5.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.