Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] kubeval: don't build against schema by default #86759

Merged
merged 2 commits into from May 4, 2020

Conversation

@johanot
Copy link
Contributor

johanot commented May 4, 2020

Motivation for this change

backport of #82816 to allow kubeval to be un-broken in 20.03.

cc @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Mic92 and others added 2 commits Mar 17, 2020
kubeval-schema is a huge 7GB repository that we do not want
to build on hydra. Therefore make it optional.

(cherry picked from commit 9d144b8)
@johanot
Copy link
Contributor Author

johanot commented May 4, 2020

Almost forgot: added an extra commit that removes the broken flag.

@Mic92
Copy link
Contributor

Mic92 commented May 4, 2020

Result of nixpkgs-review pr 86759 1

1 package built:
- kubeval
@Mic92 Mic92 merged commit 6ea8340 into NixOS:release-20.03 May 4, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f84e12"; rev="8f84e120f02ae95f75c8bafb393b90ae5bf9c3f7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f84e12"; rev="8f84e120f02ae95f75c8bafb393b90ae5bf9c3f7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f84e12"; rev="8f84e120f02ae95f75c8bafb393b90ae5bf9c3f7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f84e12"; rev="8f84e120f02ae95f75c8bafb393b90ae5bf9c3f7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f84e12"; rev="8f84e120f02ae95f75c8bafb393b90ae5bf9c3f7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f84e12"; rev="8f84e120f02ae95f75c8bafb393b90ae5bf9c3f7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8f84e12"; rev="8f84e120f02ae95f75c8bafb393b90ae5bf9c3f7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kubeval, kubeval.passthru.tests on aarch64-linux Success
Details
kubeval, kubeval.passthru.tests on x86_64-linux Success
Details
@johanot johanot deleted the johanot:backport-kubeval-fix branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.