Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] nixos/acme: update documentation #86769

Merged
merged 1 commit into from May 4, 2020

Conversation

@m1cr0man
Copy link
Contributor

m1cr0man commented May 4, 2020

Motivation for this change

Backport of #86347

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@m1cr0man
Copy link
Contributor Author

m1cr0man commented May 4, 2020

@flokli flokli merged commit 9776235 into NixOS:release-20.03 May 4, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8a8a9c2"; rev="8a8a9c28c57023fcd9e9d909bc0706d6069b67a8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8a8a9c2"; rev="8a8a9c28c57023fcd9e9d909bc0706d6069b67a8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8a8a9c2"; rev="8a8a9c28c57023fcd9e9d909bc0706d6069b67a8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8a8a9c2"; rev="8a8a9c28c57023fcd9e9d909bc0706d6069b67a8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8a8a9c2"; rev="8a8a9c28c57023fcd9e9d909bc0706d6069b67a8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8a8a9c2"; rev="8a8a9c28c57023fcd9e9d909bc0706d6069b67a8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8a8a9c2"; rev="8a8a9c28c57023fcd9e9d909bc0706d6069b67a8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@flokli
Copy link
Contributor

flokli commented May 4, 2020

Argh, I didn't check the cherry-picked-by attribute before merging this.

Please make sure to always git cherry-pick -x when backporting to stable, as described in https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches.

@m1cr0man
Copy link
Contributor Author

m1cr0man commented May 4, 2020

Ach, sorry. I intentionally squashed it too from the 3 commits down to 1. I'll have a good read through all those docs for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.