Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages: init he and escape-string-regexp #86773

Closed
wants to merge 2 commits into from

Conversation

@expipiplus1
Copy link
Contributor

expipiplus1 commented May 4, 2020

These are a prerequisite for building the Vulkan
documentation
. Vulkan-Docs
doesn't come with a well-formed package.json which makes it difficult to
use with node2nix or other tools. Having these packages here makes it
very easy.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@expipiplus1 expipiplus1 force-pushed the expipiplus1:joe-node branch from 1fde73c to 60391b7 May 31, 2020
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented May 31, 2020

@prusnak I have rebased on master.

buildInputs = globalBuildInputs;
meta = {
description = "A robust HTML entities encoder/decoder with full Unicode support.";
homepage = https://mths.be/he;

This comment has been minimized.

Copy link
@prusnak

prusnak May 31, 2020

Member

Does this come from node2nix? As per RFC45 the URLs should be quoted:

Suggested change
homepage = https://mths.be/he;
homepage = "https://mths.be/he";

This comment has been minimized.

Copy link
@expipiplus1

expipiplus1 Jun 1, 2020

Author Contributor

done, thanks

@expipiplus1 expipiplus1 force-pushed the expipiplus1:joe-node branch from 60391b7 to 558f88c Jun 1, 2020
@prusnak
prusnak approved these changes Jun 1, 2020
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Jun 10, 2020

Is it possible to get this merged, please?

@veprbl
Copy link
Member

veprbl commented Jun 11, 2020

Landed as 74ff4f6 and d6c0115

@veprbl veprbl closed this Jun 11, 2020
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Jun 11, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.