Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages: remove decentral node-packages.json files #86776

Open
wants to merge 7 commits into
base: master
from

Conversation

@Mic92
Copy link
Contributor

Mic92 commented May 4, 2020

Motivation for this change
  • reduce expression size of npm.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Mic92 Mic92 changed the title nd nodePackages: remove decentral node-packages.json files May 4, 2020
@Mic92 Mic92 marked this pull request as ready for review May 4, 2020
@Mic92 Mic92 force-pushed the Mic92:node-refactorings branch from 83a6746 to fd1531a May 4, 2020
@ofborg ofborg bot requested a review from michojel May 4, 2020
@Mic92 Mic92 force-pushed the Mic92:node-refactorings branch 2 times, most recently from c0df3f7 to 538ffcd May 9, 2020
Mic92 added 7 commits May 4, 2020
repository no longer exists
@Mic92 Mic92 force-pushed the Mic92:node-refactorings branch from 538ffcd to 2c517c4 May 9, 2020
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.