Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/yggdrasil: change config priority, persistentKeys #86778

Merged
merged 1 commit into from May 21, 2020
Merged

Conversation

@ehmry
Copy link
Member

ehmry commented May 4, 2020

Favor the configuration in "configFile" over "config" to allow
"configFile" to override "config" without a system rebuild.

Add a "persistentKeys" option to generate keys and addresses that
persist across service restarts. This is useful for self-configuring
installation media.


Motivation for this change

The Yggdrasil module should support persistent addressing without manually generating keys.

As for changes the priority of configuration values between the configuration in the nix store and mutable configuration, I thought it was more intuitive to favor the mutable (though use of mutable configuration is not encouraged). I don't have a strong opinion on this and I can change it back if its is an issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ehmry ehmry requested review from Lassulus and gazally May 4, 2020
Favor the configuration in "configFile" over "config" to allow
"configFile" to override "config" without a system rebuild.

Add a "persistentKeys" option to generate keys and addresses that
persist across service restarts. This is useful for self-configuring
boot media.
@ehmry ehmry changed the title nixos/yggdrasil: change config priority, presistentKeys nixos/yggdrasil: change config priority, persistentKeys May 4, 2020
@ehmry ehmry force-pushed the ehmry:yggdrasil branch from 67c25f1 to a886b03 May 4, 2020
@ehmry ehmry merged commit ac97b19 into NixOS:master May 21, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a886b03"; rev="a886b03e55352edfd013affdc923a750caa5ebe1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a886b03"; rev="a886b03e55352edfd013affdc923a750caa5ebe1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a886b03"; rev="a886b03e55352edfd013affdc923a750caa5ebe1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a886b03"; rev="a886b03e55352edfd013affdc923a750caa5ebe1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a886b03"; rev="a886b03e55352edfd013affdc923a750caa5ebe1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a886b03"; rev="a886b03e55352edfd013affdc923a750caa5ebe1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a886b03"; rev="a886b03e55352edfd013affdc923a750caa5ebe1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ehmry ehmry deleted the ehmry:yggdrasil branch May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.