Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.XMLRPCLite: init at 0.717 #86780

Merged
merged 1 commit into from Jun 10, 2020

Conversation

@sternenseemann
Copy link
Member

sternenseemann commented May 4, 2020

Motivation for this change

Add missing cpan package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
@sternenseemann sternenseemann force-pushed the sternenseemann:xmlrpc-lite-0.7.17 branch from 42cea7a to 439d646 May 28, 2020
@sternenseemann
Copy link
Member Author

sternenseemann commented May 28, 2020

@GrahamcOfBorg build perlPackages.XMLRPCLite

Copy link
Member

stigtsp left a comment

LGTM

@stigtsp stigtsp requested a review from aanderse May 31, 2020
@aanderse
Copy link
Contributor

aanderse commented May 31, 2020

@GrahamcOfBorg build perldevelPackages.XMLRPCLite

@aanderse
Copy link
Contributor

aanderse commented May 31, 2020

See darwin log.

Copy link
Member

stigtsp left a comment

25-xmlrpc.t tries to connect to betty.userland.com:80 which on linux results in a skipped test, but this skip is not triggered on darwin. Since this test should be skipped in any case, I recommend removing it.

pkgs/top-level/perl-packages.nix Show resolved Hide resolved
@sternenseemann sternenseemann force-pushed the sternenseemann:xmlrpc-lite-0.7.17 branch from 439d646 to f8ba613 Jun 9, 2020
@sternenseemann
Copy link
Member Author

sternenseemann commented Jun 9, 2020

@GrahamcOfBorg build perldevelPackages.XMLRPCLite

@stigtsp
stigtsp approved these changes Jun 9, 2020
@aanderse
Copy link
Contributor

aanderse commented Jun 10, 2020

@GrahamcOfBorg build perldevelPackages.XMLRPCLite

@aanderse
Copy link
Contributor

aanderse commented Jun 10, 2020

Thanks team 🎉

@aanderse aanderse merged commit 15b098b into NixOS:master Jun 10, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ba613"; rev="f8ba613f10a7ad044a06662aed3aad6c41cb956b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ba613"; rev="f8ba613f10a7ad044a06662aed3aad6c41cb956b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ba613"; rev="f8ba613f10a7ad044a06662aed3aad6c41cb956b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ba613"; rev="f8ba613f10a7ad044a06662aed3aad6c41cb956b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ba613"; rev="f8ba613f10a7ad044a06662aed3aad6c41cb956b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ba613"; rev="f8ba613f10a7ad044a06662aed3aad6c41cb956b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f8ba613"; rev="f8ba613f10a7ad044a06662aed3aad6c41cb956b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
perldevelPackages.XMLRPCLite on aarch64-linux Success
Details
perldevelPackages.XMLRPCLite on x86_64-darwin Success
Details
perldevelPackages.XMLRPCLite on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.