Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binutils: add avr-size patch #86812

Open
wants to merge 1 commit into
base: master
from
Open

binutils: add avr-size patch #86812

wants to merge 1 commit into from

Conversation

@FrozenDroid
Copy link

FrozenDroid commented May 4, 2020

Motivation for this change

I was trying to work on an AVR project and I needed to determine the flash and RAM usage, so I tried to use --mcu and -C like I always had, but that didn't work. So I found out that avr-size was really just plain GNU binutils size, and missing this patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
To bring the avr-binutils package in line with other package managers
@FrozenDroid
Copy link
Author

FrozenDroid commented May 4, 2020

Result of nixpkgs-review pr 86812 1

1 package failed to build:
- qmk_firmware
2 packages built:
- simavr
- tinygo
@FrozenDroid
Copy link
Author

FrozenDroid commented May 4, 2020

According to https://hydra.nixos.org/build/118027403, qmk's firmware last successful build was a while ago. I don't think this change causes the compilation error.

Copy link
Contributor

bjornfor left a comment

Where does the patch come from? Who is author? Can it be fetched instead of being committed to nixpkgs?

@FrozenDroid
Copy link
Author

FrozenDroid commented May 9, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.