Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: remove isPy33, isPy34 #86816

Merged
merged 1 commit into from May 5, 2020
Merged

Conversation

@prusnak
Copy link
Member

prusnak commented May 4, 2020

Motivation for this change

This PR removes the usage of isPy33 and isPy34 which are not used for anything useful anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@prusnak prusnak requested review from FRidh and jonringer as code owners May 4, 2020
@ofborg ofborg bot added the 6.topic: python label May 4, 2020
@FRidh
FRidh approved these changes May 4, 2020
Copy link
Member

FRidh left a comment

Thanks!

@prusnak prusnak force-pushed the prusnak:python-cleanup-py33-py34 branch from e1f6633 to b863625 May 4, 2020
@jonringer jonringer merged commit 420124a into NixOS:master May 5, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b863625"; rev="b863625db07b39e0fcafd32aa53323bbff73196f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b863625"; rev="b863625db07b39e0fcafd32aa53323bbff73196f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b863625"; rev="b863625db07b39e0fcafd32aa53323bbff73196f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b863625"; rev="b863625db07b39e0fcafd32aa53323bbff73196f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b863625"; rev="b863625db07b39e0fcafd32aa53323bbff73196f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b863625"; rev="b863625db07b39e0fcafd32aa53323bbff73196f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b863625"; rev="b863625db07b39e0fcafd32aa53323bbff73196f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python, python.passthru.tests on aarch64-linux Success
Details
python, python.passthru.tests on x86_64-darwin Success
Details
python, python.passthru.tests on x86_64-linux Success
Details
@jonringer
Copy link
Contributor

jonringer commented May 5, 2020

Thanks :)

@prusnak prusnak deleted the prusnak:python-cleanup-py33-py34 branch May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.