Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kloak: init at v0.2 #86824

Open
wants to merge 1 commit into
base: master
from
Open

kloak: init at v0.2 #86824

wants to merge 1 commit into from

Conversation

@ryneeverett
Copy link
Contributor

ryneeverett commented May 4, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pname = "kloak";
version = "v0.2";

src = fetchgit {

This comment has been minimized.

Copy link
@mweinelt

src = fetchgit {
url = "https://github.com/vmonaco/kloak.git";
rev = "49ca7208f15b976b51df23666667f14c63a631d7";

This comment has been minimized.

Copy link
@mweinelt

mweinelt May 8, 2020

Member
Suggested change
rev = "49ca7208f15b976b51df23666667f14c63a631d7";
rev = "${version}";
@ryneeverett ryneeverett force-pushed the ryneeverett:kloak-init branch from 30fb56f to 6c5da9c May 9, 2020
@ryneeverett
Copy link
Contributor Author

ryneeverett commented May 9, 2020

Thanks for the review @mweinelt!

I wasn't sure if the website-specific fetchers were preferred but I'm happy to defer to your judgement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.