Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/filesystems/zfs: use current kernel #86835

Closed
wants to merge 1 commit into from

Conversation

@eadwu
Copy link
Member

eadwu commented May 4, 2020

Motivation for this change

The derivation for zfs currently doesn't pull in the same kernel if boot.kernel.randstructSeed is set to a non-zero length string resulting in an extra kernel to build while also basically destroying the purpose of setting a randstructSeed, since the kernel used to build zfs would use a different seed.

Using callPackage should also work since kernel won't be evaluated until the derivation is called, in which case the kernel would've been updated (I believe), but I'm not sure how that should be done without using a let/in block (which probably should be in all-packages.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

[1] https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/all-packages.nix#L16933

@eadwu eadwu force-pushed the eadwu:zfs/same-kernel branch from a1eb195 to 3542551 May 7, 2020
@eadwu eadwu force-pushed the eadwu:zfs/same-kernel branch from 3542551 to a1eb195 May 7, 2020
@eadwu eadwu mentioned this pull request May 9, 2020
2 of 10 tasks complete
@eadwu eadwu closed this May 15, 2020
@eadwu eadwu deleted the eadwu:zfs/same-kernel branch May 15, 2020
@eadwu
Copy link
Member Author

eadwu commented May 15, 2020

Hopefully superseded by #87856.

@wizeman wizeman mentioned this pull request Jun 19, 2020
2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.