Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] openshot-qt: 2.4.4 -> 2.5.1 #86841

Merged
merged 3 commits into from May 5, 2020
Merged

Conversation

@vbgl
Copy link
Contributor

vbgl commented May 4, 2020

Port of #83165 to 20.03.

Motivation for this change

openshot-qt is currently marked as broken

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @AndersonTorres

(cherry picked from commit ab7647b)
(cherry picked from commit 71ab434)
(cherry picked from commit 5f38229)
Copy link
Contributor

jonringer left a comment

diff LGTM
gui launches fine

[4 built, 35 copied (248.7 MiB), 29.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/86841
3 package built:
libsForQt5.libopenshot libsForQt5.libopenshot-audio openshot-qt
@jonringer jonringer merged commit e5cb3ef into NixOS:release-20.03 May 5, 2020
17 checks passed
17 checks passed
openshot-qt, openshot-qt.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3cd18e5"; rev="3cd18e5e6cd0a69d83b2d588127ac1a566262d37"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3cd18e5"; rev="3cd18e5e6cd0a69d83b2d588127ac1a566262d37"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3cd18e5"; rev="3cd18e5e6cd0a69d83b2d588127ac1a566262d37"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3cd18e5"; rev="3cd18e5e6cd0a69d83b2d588127ac1a566262d37"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3cd18e5"; rev="3cd18e5e6cd0a69d83b2d588127ac1a566262d37"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3cd18e5"; rev="3cd18e5e6cd0a69d83b2d588127ac1a566262d37"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3cd18e5"; rev="3cd18e5e6cd0a69d83b2d588127ac1a566262d37"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
openshot-qt, openshot-qt.passthru.tests on aarch64-linux Success
Details
openshot-qt, openshot-qt.passthru.tests on x86_64-linux Success
Details
@vbgl vbgl deleted the vbgl:openshot-qt-2.5.1 branch May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.