Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libxcrypt: init at 4.4.16 #86851

Open
wants to merge 1 commit into
base: master
from
Open

libxcrypt: init at 4.4.16 #86851

wants to merge 1 commit into from

Conversation

@leenaars
Copy link
Contributor

leenaars commented May 4, 2020

Motivation for this change

Useful library that is part of many other distros:
https://repology.org/project/libxcrypt/packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
./autogen.sh
'';

configureFlags = stdenv.lib.optional stdenv.hostPlatform.isx86 "--enable-fat=yes";

This comment has been minimized.

Copy link
@doronbehar

doronbehar May 23, 2020

Contributor

Personal taste of mine:

Suggested change
configureFlags = stdenv.lib.optional stdenv.hostPlatform.isx86 "--enable-fat=yes";
configureFlags = [
]
++ stdenv.lib.optionals stdenv.hostPlatform.isx86 [ "--enable-fat=yes" ]
;

This makes future diffs cleaner.


configureFlags = stdenv.lib.optional stdenv.hostPlatform.isx86 "--enable-fat=yes";

nativeBuildInputs = [ autoconf automake libtool pkg-config ];

This comment has been minimized.

Copy link
@doronbehar

doronbehar May 23, 2020

Contributor

Use autoreconfHook and remove that preConfigure.

@@ -0,0 +1,32 @@
{ stdenv, fetchFromGitHub, autoconf, automake, libtool, pkg-config }:

This comment has been minimized.

Copy link
@doronbehar

doronbehar May 23, 2020

Contributor

Following my personal taste comment:

Suggested change
{ stdenv, fetchFromGitHub, autoconf, automake, libtool, pkg-config }:
{ stdenv
,fetchFromGitHub
,autoreconfHook
,libtool
,pkg-config
}:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.