Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btrfs-heatmap: init at v8-1; incl. python.pkgs.btrfs #86861

Open
wants to merge 2 commits into
base: master
from

Conversation

@evils
Copy link
Contributor

evils commented May 5, 2020

Motivation for this change

pretty pictures
cruft

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • /nix/store/icvlas78f6xanwl8fv4fsf9g0932gm91-btrfs-heatmap-8-1 106812480
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rardiol
Copy link
Contributor

rardiol commented May 5, 2020

pretty pictures working for me.

edit: platforms could be set to linux as this apparently uses low level kernel calls that will only work on linux.

@evils evils force-pushed the evils:btrfs-heatmap branch from 81ac85a to d67e3a0 May 6, 2020
@evils evils force-pushed the evils:btrfs-heatmap branch from d67e3a0 to 7a4934e Jun 28, 2020
@evils evils changed the title btrfs-heatmap: init at v8-1; incl. pythonPackages.btrfs btrfs-heatmap: init at v8-1; incl. python.pkgs.btrfs Jun 28, 2020
@evils evils force-pushed the evils:btrfs-heatmap branch from 7a4934e to 8646562 Jun 28, 2020
@evils
Copy link
Contributor Author

evils commented Jun 28, 2020

/marvin opt-in
/status needs_review

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 28, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.