Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pyln-client: init at 0.8.0 #86882

Open
wants to merge 3 commits into
base: master
from

Conversation

@zhenyavinogradov
Copy link
Contributor

zhenyavinogradov commented May 5, 2020

Motivation for this change

pyln-client is a client library for lightningd daemon: https://pypi.org/project/pyln-client/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@zhenyavinogradov zhenyavinogradov requested review from FRidh and jonringer as code owners May 5, 2020
@ofborg ofborg bot added the 6.topic: python label May 5, 2020
@kirelagin
Copy link
Member

kirelagin commented May 5, 2020

This obsoletes #68311, since pylightning is now kinda deprecated (they don’t state this anywhere explicitly, but what is happening is they are breaking their Python bindings into better organised modules, and at this time pylightning is just a compatibility shim around pyln-client). Plugins are being switched to pyln-client instead of pylightning too.

@kirelagin
Copy link
Member

kirelagin commented May 5, 2020

(Also, fwiw, works on macOS just fine.)


meta = with lib; {
description = "Client library for lightningd";
homepage = https://github.com/ElementsProject/lightning;

This comment has been minimized.

@jonringer

jonringer May 15, 2020 Contributor

rfc 45

Suggested change
homepage = https://github.com/ElementsProject/lightning;
homepage = "https://github.com/ElementsProject/lightning";

This comment has been minimized.

@zhenyavinogradov

zhenyavinogradov May 15, 2020 Author Contributor

Applied

@@ -7328,6 +7328,8 @@ in {

rxv = callPackage ../development/python-modules/rxv { };

pyln-client = callPackage ../development/python-modules/pyln-client { };

This comment has been minimized.

@jonringer

jonringer May 15, 2020 Contributor

please attempt to order this

This comment has been minimized.

@zhenyavinogradov

zhenyavinogradov May 15, 2020 Author Contributor

Ok, I tried

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.