Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitkraken: 6.5.4 -> 6.6.0 #86893

Merged
merged 1 commit into from May 11, 2020
Merged

gitkraken: 6.5.4 -> 6.6.0 #86893

merged 1 commit into from May 11, 2020

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented May 5, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gitkraken/versions.

meta.description for gitkraken is: "The downright luxurious and most popular Git client for Windows, Mac & Linux"

meta.homepage for gitkraken is: "https://www.gitkraken.com/"

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
gitkraken
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/ip7azp5lx4l7faqckw8s86vy9ri3p374-gitkraken-6.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gitkraken https://github.com/r-ryantm/nixpkgs/archive/8244a7b6827e805bc77a8e24df4d7faad54ad172.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/ip7azp5lx4l7faqckw8s86vy9ri3p374-gitkraken-6.6.0
ls -la /nix/store/ip7azp5lx4l7faqckw8s86vy9ri3p374-gitkraken-6.6.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
- gitkraken

Maintainer pings

cc @xNWDD @evanjs for testing.

@drewrisinger
Copy link
Contributor

drewrisinger commented May 5, 2020

Builds locally with nixpkgs-review pr 86893, but has errors when running.
@xNWDD @evanjs for debugging

[nix-shell:~/.cache/nixpkgs-review/pr-86893]$ gitkraken
Gtk-Message: 11:50:24.612: Failed to load module "canberra-gtk-module"
Gtk-Message: 11:50:24.613: Failed to load module "canberra-gtk-module"
Error: libsecret-1.so.0: cannot open shared object file: No such file or directory
    at process.func (electron/js2c/asar.js:140:31)
    at process.func [as dlopen] (electron/js2c/asar.js:140:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:922:18)
    at Object.func (electron/js2c/asar.js:140:31)
    at Object.func [as .node] (electron/js2c/asar.js:149:18)
    at Module.load (internal/modules/cjs/loader.js:735:32)
    at Module._load (internal/modules/cjs/loader.js:648:12)
    at Module._load (electron/js2c/asar.js:717:26)
    at Function.Module._load (electron/js2c/asar.js:717:26)
    at Module.require (internal/modules/cjs/loader.js:775:19)

[nix-shell:~/.cache/nixpkgs-review/pr-86893]$ gitkraken --version
Gtk-Message: 11:50:33.861: Failed to load module "canberra-gtk-module"
Gtk-Message: 11:50:33.862: Failed to load module "canberra-gtk-module"
6.6.0
@evanjs
Copy link
Member

evanjs commented May 5, 2020

Looks like we might need to add a dep. I’ll take a look when I get a chance later today.

Thanks for the stdout @drewrisinger!

@evanjs
Copy link
Member

evanjs commented May 5, 2020

Interesting... no issues on my machine....
Runs locally via gitkraken after building via nixpkgs-review pr 86893.

@evanjs
Copy link
Member

evanjs commented May 5, 2020

@drewrisinger what is the output of nix-info -m?

@jonringer
Copy link
Contributor

jonringer commented May 6, 2020

probably something with your configuration.nix is making it work. Only thing i could think of is dbus packages

@drewrisinger
Copy link
Contributor

drewrisinger commented May 6, 2020

@drewrisinger what is the output of nix-info -m?

 - system: `"x86_64-linux"`
 - host os: `Linux 4.15.0-91-generic, Ubuntu, 18.04.4 LTS (Bionic Beaver)`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.1`
 - channels(NAME): `"artiq-full, nixpkgs-19.09.2477.a7ceb2536ab"`
 - nixpkgs: `/home/NAME/.nix-defexpr/channels/nixpkgs`

Note: ARTIQ full is https://nixbld.m-labs.hk/jobset/artiq/full

@evanjs
Copy link
Member

evanjs commented May 10, 2020

Builds locally with nixpkgs-review pr 86893, but has errors when running.
@xNWDD @evanjs for debugging

[nix-shell:~/.cache/nixpkgs-review/pr-86893]$ gitkraken
Gtk-Message: 11:50:24.612: Failed to load module "canberra-gtk-module"
Gtk-Message: 11:50:24.613: Failed to load module "canberra-gtk-module"
Error: libsecret-1.so.0: cannot open shared object file: No such file or directory
    at process.func (electron/js2c/asar.js:140:31)
    at process.func [as dlopen] (electron/js2c/asar.js:140:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:922:18)
    at Object.func (electron/js2c/asar.js:140:31)
    at Object.func [as .node] (electron/js2c/asar.js:149:18)
    at Module.load (internal/modules/cjs/loader.js:735:32)
    at Module._load (internal/modules/cjs/loader.js:648:12)
    at Module._load (electron/js2c/asar.js:717:26)
    at Function.Module._load (electron/js2c/asar.js:717:26)
    at Module.require (internal/modules/cjs/loader.js:775:19)

[nix-shell:~/.cache/nixpkgs-review/pr-86893]$ gitkraken --version
Gtk-Message: 11:50:33.861: Failed to load module "canberra-gtk-module"
Gtk-Message: 11:50:33.862: Failed to load module "canberra-gtk-module"
6.6.0

Okay, so I think I misread this at first...
I initially thought you meant it wouldn't open at all.
After getting a VM for 18.04 set up, I can see the same errors.
However.... I'm going to wager this might not be supported

After digging a little deeper, as things initially seem fine in ldd...

ldd /nix/store/ip7azp5lx4l7faqckw8s86vy9ri3p374-gitkraken-6.6.0/share/gitkraken/gitkraken | rg not
/nix/store/ip7azp5lx4l7faqckw8s86vy9ri3p374-gitkraken-6.6.0/share/gitkraken/gitkraken: 
/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found
(required by /nix/store/q5610fnxykkwl3miv86cs2rg5v31hrwv-glib-2.64.1/lib/libglib-2.0.so.0)

I have no idea what our GLIBC compatibility story looks like for older versions of NixOS, let alone older versions of other distros.

At any rate, I was able to run this all just fine without these errors on a NixOS vm with an empty config + gitkraken + i3, so I don't think this is dependency-based, and seems to be related to Bionic Beaver using a different glibc, if I understand correctly.

@evanjs
evanjs approved these changes May 10, 2020
Copy link
Member

evanjs left a comment

Compatibility with older non-NixOS distributions (due to different GLIBC versions?) aside, this looks good and seems to work fine for me.

@ryantm ryantm merged commit b970793 into NixOS:master May 11, 2020
17 checks passed
17 checks passed
gitkraken, gitkraken.passthru.tests on aarch64-linux No attempt
Details
gitkraken, gitkraken.passthru.tests on x86_64-darwin No attempt
Details
gitkraken, gitkraken.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8244a7b"; rev="8244a7b6827e805bc77a8e24df4d7faad54ad172"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8244a7b"; rev="8244a7b6827e805bc77a8e24df4d7faad54ad172"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8244a7b"; rev="8244a7b6827e805bc77a8e24df4d7faad54ad172"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8244a7b"; rev="8244a7b6827e805bc77a8e24df4d7faad54ad172"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8244a7b"; rev="8244a7b6827e805bc77a8e24df4d7faad54ad172"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8244a7b"; rev="8244a7b6827e805bc77a8e24df4d7faad54ad172"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8244a7b"; rev="8244a7b6827e805bc77a8e24df4d7faad54ad172"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/gitkraken branch May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.