Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/pantheon: mkDefault value for defaultSession #86908

Merged
merged 1 commit into from May 5, 2020

Conversation

@cptMikky
Copy link
Contributor

cptMikky commented May 5, 2020

Motivation for this change

Fixes #86907

Things done

Set defaultSession using mkDefault, not directly, to prevent conflicts.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Member

worldofpeace commented May 5, 2020

@ofborg test pantheon

Copy link
Member

worldofpeace left a comment

Please change commit message to

nixos/pantheon: mkDefault value for defaultSession

Fixes #86907
@cptMikky cptMikky force-pushed the cptMikky:pantheon-nodefault branch from e0ff912 to c04989d May 5, 2020
@cptMikky cptMikky changed the title Make 'pantheon' a 'mkDefault' value for defaultSession nixos/pantheon: mkDefault value for defaultSession May 5, 2020
@cptMikky cptMikky requested a review from worldofpeace May 5, 2020
@worldofpeace worldofpeace merged commit 4ad2e1c into NixOS:master May 5, 2020
@worldofpeace
Copy link
Member

worldofpeace commented May 5, 2020

backported to 20.03 in 425aeec

@worldofpeace
Copy link
Member

worldofpeace commented May 5, 2020

Thanks for fixing this @cptMikky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.