Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnujump: install desktop file #86913

Open
wants to merge 1 commit into
base: master
from
Open

gnujump: install desktop file #86913

wants to merge 1 commit into from

Conversation

@iblech
Copy link
Contributor

iblech commented May 5, 2020

Motivation for this change

Thank you, @fgaz, for maintaining gnujump! As described in #86906, I cannot actually test gnujump right now, but this pull request nevertheless adds a desktop entry for gnujump (lifted from Debian).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
mkdir -p $out/share/applications $out/share/pixmaps
cat > $out/share/applications/gnujump.desktop <<EOF
[Desktop Entry]

This comment has been minimized.

Copy link
@doronbehar

doronbehar May 5, 2020

Contributor

There's an undocumented Nix function made for this: makeDesktopItem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.