Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frozen-bubble: install desktop file #86914

Open
wants to merge 1 commit into
base: master
from
Open

frozen-bubble: install desktop file #86914

wants to merge 1 commit into from

Conversation

@iblech
Copy link
Contributor

iblech commented May 5, 2020

Motivation for this change

Thank you, @puckipedia, for maintaining Frozen Bubble in nixpkgs! This pull request just adds a desktop file (lifted from Debian) together with appropriate icons (which are already part of the upstream package).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

puckipedia left a comment

Awesome! I use a DE without desktop entry support, so I missed this in my time porting it. There's two small issues I'd like to see resolved before approving, see comments.

cat > $out/share/applications/frozen-bubble.desktop <<EOF
[Desktop Entry]
Name=Frozen-Bubble
Comment=Pop out the bubbles!
Exec=$out/bin/frozen-bubble
Icon=frozen-bubble
Terminal=false
X-MultipleArgs=false
Type=Application
Categories=Game;ArcadeGame;
Keywords=game;bubbles;pop;
EOF
Comment on lines +22 to +33

This comment has been minimized.

Copy link
@puckipedia

puckipedia May 5, 2020

Contributor

It'd be a bit cleaner to move this to a separate file and substituteAll it over into the right directory, IMO.

This comment has been minimized.

Copy link
@teto

teto May 5, 2020

Contributor

nix has a makeDesktopItem utility to generate desktop entries when upstream hasn't any.

@@ -16,6 +16,27 @@ perlPackages.buildPerlModule {
propagatedBuildInputs = with perlPackages; [ AlienSDL CompressBzip2 FileShareDir FileWhich IPCSystemSimple LocaleMaketextLexicon ];

perlPreHook = "export LD=$CC";

This comment has been minimized.

Copy link
@puckipedia

puckipedia May 5, 2020

Contributor

Trailing whitespace (I think? Github doesn't show it, but my local git does.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.