Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exoscale-cli: init at 1.12.0 #86927

Merged
merged 2 commits into from May 12, 2020
Merged

exoscale-cli: init at 1.12.0 #86927

merged 2 commits into from May 12, 2020

Conversation

@dramaturg
Copy link
Contributor

dramaturg commented May 5, 2020

Motivation for this change

Add a derivation the Exoscales cli tool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
@dramaturg dramaturg force-pushed the dramaturg:exoscale-cli branch from d18222b to f39df29 May 5, 2020
@dramaturg
Copy link
Contributor Author

dramaturg commented May 5, 2020

@doronbehar thank you for your patient review - this is my first upstream nix package :-)

pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/exoscale-cli/default.nix Outdated Show resolved Hide resolved
@dramaturg dramaturg force-pushed the dramaturg:exoscale-cli branch 2 times, most recently from e351e41 to 771c105 May 5, 2020
@dramaturg dramaturg force-pushed the dramaturg:exoscale-cli branch from 771c105 to 8bd1075 May 6, 2020
@doronbehar
Copy link
Contributor

doronbehar commented May 8, 2020

Sorry for the duplicates ^, but you should be good to go after these.

@dramaturg dramaturg force-pushed the dramaturg:exoscale-cli branch from 8bd1075 to 5e337ad May 8, 2020
@nixos-discourse
Copy link

nixos-discourse commented May 11, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/153

@AndersonTorres AndersonTorres merged commit 1233db8 into NixOS:master May 12, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
exoscale-cli, exoscale-cli.passthru.tests on aarch64-linux Success
Details
exoscale-cli, exoscale-cli.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e337ad"; rev="5e337ad90bfcd420871cb9d641d7dfdc5a164c29"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e337ad"; rev="5e337ad90bfcd420871cb9d641d7dfdc5a164c29"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e337ad"; rev="5e337ad90bfcd420871cb9d641d7dfdc5a164c29"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e337ad"; rev="5e337ad90bfcd420871cb9d641d7dfdc5a164c29"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e337ad"; rev="5e337ad90bfcd420871cb9d641d7dfdc5a164c29"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e337ad"; rev="5e337ad90bfcd420871cb9d641d7dfdc5a164c29"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e337ad"; rev="5e337ad90bfcd420871cb9d641d7dfdc5a164c29"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.