Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopass: Adapt to buildGoModule output naming scheme #86977

Merged
merged 1 commit into from May 6, 2020

Conversation

@rvolosatovs
Copy link
Contributor

rvolosatovs commented May 5, 2020

Motivation for this change

Turns out there's another rebase artifact in #85521 - since switch to buildGoModule $bin output does not exist anymore, use $out instead

cc @andir

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rvolosatovs rvolosatovs force-pushed the rvolosatovs:fix/gopass-alias branch from 36a4bab to 93dd4b5 May 5, 2020
@rvolosatovs
Copy link
Contributor Author

rvolosatovs commented May 5, 2020

@GrahamcOfBorg build gopass

@marsam marsam merged commit b290ef6 into NixOS:master May 6, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gopass on aarch64-linux Success
Details
gopass on x86_64-linux Success
Details
gopass, gopass.passthru.tests on aarch64-linux Success
Details
gopass, gopass.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93dd4b5"; rev="93dd4b51185f7e5609aa2225ee51123eb9072853"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93dd4b5"; rev="93dd4b51185f7e5609aa2225ee51123eb9072853"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93dd4b5"; rev="93dd4b51185f7e5609aa2225ee51123eb9072853"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93dd4b5"; rev="93dd4b51185f7e5609aa2225ee51123eb9072853"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93dd4b5"; rev="93dd4b51185f7e5609aa2225ee51123eb9072853"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93dd4b5"; rev="93dd4b51185f7e5609aa2225ee51123eb9072853"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="93dd4b5"; rev="93dd4b51185f7e5609aa2225ee51123eb9072853"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@rvolosatovs rvolosatovs deleted the rvolosatovs:fix/gopass-alias branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.