Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tome4: fix typo in .desktop file #86982

Open
wants to merge 3 commits into
base: master
from
Open

tome4: fix typo in .desktop file #86982

wants to merge 3 commits into from

Conversation

@rardiol
Copy link
Contributor

rardiol commented May 5, 2020

Motivation for this change

/nix/store/chdryz9m1nfkjkw9ji9lwdnck8201szv-tome4.desktop/share/applications/tome4.desktop: error: value "False" for boolean key "Terminal" in group "Desktop Entry" contains invalid characters, boolean values must be "false" or "true"

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rardiol
Copy link
Contributor Author

rardiol commented May 6, 2020

Went ahead and fixed it for tdm and tome2. Note I didn't test the packages, but the .desktop files build now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.