Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor: 0.7.1 -> 0.7.2 #86983

Merged
merged 2 commits into from May 9, 2020
Merged

monitor: 0.7.1 -> 0.7.2 #86983

merged 2 commits into from May 9, 2020

Conversation

@xiorcale
Copy link
Contributor

xiorcale commented May 5, 2020

Motivation for this change

see: https://github.com/stsdc/monitor/releases/tag/0.7.2

(As a side note, I changed my GitHub username without thinking about the side effect it would have on the nixpkgs I maintain. Should I make a pull request to update it, or leave it as it is now ? As I've understood, people can always find me through my GitHub id anyway)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@worldofpeace
Copy link
Member

worldofpeace commented May 5, 2020

(As a side note, I changed my GitHub username without thinking about the side effect it would have on the nixpkgs I maintain. Should I make a pull request to update it, or leave it as it is now ?

It would be great if that attribute was the same as your github username.

@xiorcale
Copy link
Contributor Author

xiorcale commented May 5, 2020

Can i do this in this PR or is it cleaner if I open a new one specifically for that and then update this one once it's merged ?

@ryantm
Copy link
Member

ryantm commented May 8, 2020

@xiorcale It is okay to do it in this PR, but it should be a separate commit.

@FRidh FRidh merged commit ccfe14c into NixOS:master May 9, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b16a3e"; rev="0b16a3e9bbfefd5c4b9ed71c5af6fd7b209b0239"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b16a3e"; rev="0b16a3e9bbfefd5c4b9ed71c5af6fd7b209b0239"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b16a3e"; rev="0b16a3e9bbfefd5c4b9ed71c5af6fd7b209b0239"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b16a3e"; rev="0b16a3e9bbfefd5c4b9ed71c5af6fd7b209b0239"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b16a3e"; rev="0b16a3e9bbfefd5c4b9ed71c5af6fd7b209b0239"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b16a3e"; rev="0b16a3e9bbfefd5c4b9ed71c5af6fd7b209b0239"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0b16a3e"; rev="0b16a3e9bbfefd5c4b9ed71c5af6fd7b209b0239"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
monitor, monitor.passthru.tests on aarch64-linux Success
Details
monitor, monitor.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.