Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.heudiconv: init at 0.8.0 #86984

Merged
merged 2 commits into from May 7, 2020
Merged

Conversation

@bcdarwin
Copy link
Member

bcdarwin commented May 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    One of the CLI scripts (heudiconv_monitor) is not working. It is possible to get this to work by adding the inotify package (dsoprea/PyInotify) to Nixpkgs, but this fails some tests and so is perhaps not working correctly, and anyway examining the optional vs mandatory dependencies for heudiconv and those used only by this script and its tests suggests heudiconv_monitor is optional anyway.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bcdarwin bcdarwin requested review from FRidh and jonringer as code owners May 5, 2020
@bcdarwin bcdarwin force-pushed the bcdarwin:heudiconv branch from 29ca33b to 55f93d4 May 5, 2020
@bcdarwin bcdarwin changed the title python3Packages.heudiconv: init at 0.6.0 python3Packages.heudiconv: init at 0.8.0 May 5, 2020
@ofborg ofborg bot added the 6.topic: python label May 5, 2020
Copy link
Contributor

jonringer left a comment

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/86984
31 package marked as broken and skipped:
digitalbitbox glibcCross iterm2 linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 muslCross nix-linter octave-jit php73Extensions.zmq php74Extensions.couchbase php74Extensions.pcs php74Extensions.zmq python27Packages.caffe python27Packages.habanero python27Packages.handout python27Packages.hass-nabucasa python37Packages.nixpart python37Packages.notify python37Packages.pyblock python38Packages.heudiconv python38Packages.libselinux python38Packages.nixpart python38Packages.notify

1 package built:
python37Packages.heudiconv
@jonringer jonringer merged commit 81be227 into NixOS:master May 7, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Checking original out paths
Details
@bcdarwin bcdarwin deleted the bcdarwin:heudiconv branch May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.