Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herbstluftwm: 0.8.1 -> 0.8.2 + add test #87003

Open
wants to merge 4 commits into
base: master
from

Conversation

@ThibautMarty
Copy link
Contributor

ThibautMarty commented May 5, 2020

Motivation for this change
  • update to last version
  • change maintainership because previous maintainer did not respond for a long time and several mentions.
  • add a simple NixOS test (based on i3wm.nix)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@FRidh
Copy link
Member

FRidh commented May 9, 2020

@GrahamcOfBorg build herbstluftwm.passthru.tests

@Lassulus
Copy link
Contributor

Lassulus commented May 12, 2020

please rebase, the maintainers entry was already removed

@ThibautMarty ThibautMarty force-pushed the ThibautMarty:herbstluftwm-0.8.2 branch from a38720a to 0c3ad90 May 22, 2020
@ThibautMarty
Copy link
Contributor Author

ThibautMarty commented May 22, 2020

done

@Lassulus
Copy link
Contributor

Lassulus commented May 22, 2020

running the test gives me this:

ensure we can open a new terminal
machine: sending monitor command: sendkey alt-ret
machine # [   65.547303] nscd[824]: 824 checking for monitored file `/etc/netgroup': No such file or directory
machine: Waiting for a window to appear
machine: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d'
(0.15 seconds)
machine: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d'
(0.11 seconds)
machine: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d'
(0.16 seconds)
machine: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d'
(0.13 seconds)
machine: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d'
(0.10 seconds)
machine # [   71.112872] xsession[1072]: /nix/store/by1dhhi4jrk3iva3rgrf007254m1lfbp-herbstluftwm-0.8.2/etc/xdg/herbstluftwm/autostart: line 168: /etc/xdg/herbstluftwm/panel.sh: No such file or directory
machine: must succeed: xwininfo -root -tree | sed 's/.*0x[0-9a-f]* \"\([^\"]*\)\".*/\1/; t; d'
(0.06 seconds)
@ThibautMarty
Copy link
Contributor Author

ThibautMarty commented May 22, 2020

The panel.sh script path is hardcoded in the provided autostart script.
For me, this is not a big deal as I suppose that anyone using such window manager will make her own configuration.
This should be fixed upstream, but I can make a patch for it, like:

patchPhase = ''
  substituteInPlace share/autostart --replace /etc $out/etc
'';

But even with this patch, the script will fail with this message: This script requires the textwidth tool of the dzen2 project. and I don't want to include such false dependencies in the package's closure.
They could be added to the test though:

environment.systemPackages = [ pkgs.dzen2 ];

Is this what you noticed or did I miss something else?

(I found a comment #For guix while digging the provided script, and that made me happy.)

Copy link
Contributor

bhipple left a comment

Needs rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.