Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
nixosTests.ldap: remove #87004
Motivation for this change
This tests seem to have worked in 15f105d, but
The current module doesn't seem to be generally usable and might need a
On top of that, the test has been broken since 2020-01-12 (5 months), so
Let's drop the test and throw a big deprecation warning to alert
As per #86305 (comment), the module works pretty well for basic usage, though maybe (I've never administered a complex LDAP server) it isn't adapted to complex use cases.
So IMO if we just deprecate/remove this without proposing anything better, we then lose the “simple” use case just working, and don't get the complex use cases working any better. I'm not sure what this would thus bring, though I totally understand that with the information available before my comment there it was the only reasonable thing to do :)
This seems to have worked in 15f105d (5 months ago) but broke somewhere in the meantime. The current module doesn't seem to be underdocumented and might need a serious refactor. It requires quite some hacks to get it to work (see #86305 (comment)), or how the ldap.nix test used systemd.services.openldap.preStart and made quite some assumptions on internals. Mic92 agreed on being added as a maintainer for the module, as he uses it a lot and can possibly fix eventual breakages. For the most basic startup breakages, the remaining openldap.nix test might suffice.