Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.ldap: remove #87004

Merged
merged 1 commit into from May 6, 2020
Merged

nixosTests.ldap: remove #87004

merged 1 commit into from May 6, 2020

Conversation

@flokli
Copy link
Contributor

flokli commented May 5, 2020

Motivation for this change

This tests seem to have worked in 15f105d, but
broke somewhere in the meantime.

The current module doesn't seem to be generally usable and might need a
serious refactor. It requires quite some hacks to get it to work (see
#86305 (comment)),
or how the test used systemd.services.openldap.preStart and made quite
some assumptions on internals.

On top of that, the test has been broken since 2020-01-12 (5 months), so
there's no guarantee this works at all.

Let's drop the test and throw a big deprecation warning to alert
everyone still using the module, and if nobody speaks up, remove it as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@flokli flokli requested review from Mic92, montag451, Ekleog and dasJ May 5, 2020
@flokli flokli changed the title nixosTests.ldap: remove, depreate nixos/openldap nixosTests.ldap: remove, deprecate nixos/openldap May 5, 2020
@Ekleog
Copy link
Member

Ekleog commented May 6, 2020

As per #86305 (comment), the module works pretty well for basic usage, though maybe (I've never administered a complex LDAP server) it isn't adapted to complex use cases.

So IMO if we just deprecate/remove this without proposing anything better, we then lose the “simple” use case just working, and don't get the complex use cases working any better. I'm not sure what this would thus bring, though I totally understand that with the information available before my comment there it was the only reasonable thing to do :)

@flokli
Copy link
Contributor Author

flokli commented May 6, 2020

As per #86305 (comment), if there's a more simpler way to test basic functionality, such a VM test would help to verify (some) things are still working.

Would you be willing to add a simple VM test on top?

@Mic92
Copy link
Contributor

Mic92 commented May 6, 2020

@flokli
Copy link
Contributor Author

flokli commented May 6, 2020

@Mic92 thanks! In that case, feel free to ping me on the PR :-)

This seems to have worked in 15f105d (5
months ago) but broke somewhere in the meantime.

The current module doesn't seem to be underdocumented and might need a
serious refactor. It requires quite some hacks to get it to work (see
#86305 (comment)),
or how the ldap.nix test used systemd.services.openldap.preStart and
made quite some assumptions on internals.

Mic92 agreed on being added as a maintainer for the module, as he uses
it a lot and can possibly fix eventual breakages. For the most basic
startup breakages, the remaining openldap.nix test might suffice.
@flokli flokli force-pushed the flokli:nixos-tests-remove-ldap branch from 93aaf9a to 450f8a4 May 6, 2020
@flokli flokli changed the title nixosTests.ldap: remove, deprecate nixos/openldap nixosTests.ldap: remove May 6, 2020
@flokli
Copy link
Contributor Author

flokli commented May 6, 2020

@Mic92 I pushed a new commit that only removes the broken VM tests, and adds you as a maintainer to the openldap module. The openldap.nix vm test is left as it is (and was all the time)

@Mic92
Mic92 approved these changes May 6, 2020
@flokli flokli merged commit 50aba11 into NixOS:master May 6, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="450f8a4"; rev="450f8a44f9bbfdea26fa4f4c26a62a5e7ac8fe4d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="450f8a4"; rev="450f8a44f9bbfdea26fa4f4c26a62a5e7ac8fe4d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="450f8a4"; rev="450f8a44f9bbfdea26fa4f4c26a62a5e7ac8fe4d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="450f8a4"; rev="450f8a44f9bbfdea26fa4f4c26a62a5e7ac8fe4d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="450f8a4"; rev="450f8a44f9bbfdea26fa4f4c26a62a5e7ac8fe4d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="450f8a4"; rev="450f8a44f9bbfdea26fa4f4c26a62a5e7ac8fe4d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="450f8a4"; rev="450f8a44f9bbfdea26fa4f4c26a62a5e7ac8fe4d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@flokli flokli deleted the flokli:nixos-tests-remove-ldap branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.