Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf: 3.7 -> 3.8 #87014

Merged
merged 1 commit into from May 7, 2020
Merged

protobuf: 3.7 -> 3.8 #87014

merged 1 commit into from May 7, 2020

Conversation

@bhipple
Copy link
Contributor

bhipple commented May 5, 2020

This is needed by newer versions of tensorflow and other ML tools, so we
should start working on an upgrade of the default versoin in the distribution.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This is needed by newer versions of `tensorflow` and other ML tools, so we
should start working on an upgrade of the default versoin in the distribution.
@drewrisinger
Copy link
Contributor

drewrisinger commented May 7, 2020

Thanks for doing this. I ran into an issue with the default version when packaging python3Packages.cirq (requires pythonPackages.protobuf==protobuf>=3.8), and it's difficult to workaround in the Python ecosystem b/c of python environment conflicts.

Copy link
Contributor

jonringer left a comment

I don't have my monster server, so i can't test this, but LGTM

@bhipple
Copy link
Contributor Author

bhipple commented May 7, 2020

Yeah, this would be a fun one to do a big nixpkgs-review on. The upstream release notes look quite tame, though, so I think we'll be fine -- in fact I expect it to solve quite a few problems :)

@bhipple bhipple merged commit 665a260 into NixOS:staging May 7, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b97f708"; rev="b97f7088c771f7e134facd97fbcacc8a9838684d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b97f708"; rev="b97f7088c771f7e134facd97fbcacc8a9838684d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b97f708"; rev="b97f7088c771f7e134facd97fbcacc8a9838684d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b97f708"; rev="b97f7088c771f7e134facd97fbcacc8a9838684d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b97f708"; rev="b97f7088c771f7e134facd97fbcacc8a9838684d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b97f708"; rev="b97f7088c771f7e134facd97fbcacc8a9838684d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b97f708"; rev="b97f7088c771f7e134facd97fbcacc8a9838684d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
protobuf, protobuf.passthru.tests on aarch64-linux Success
Details
protobuf, protobuf.passthru.tests on x86_64-linux Success
Details
@marsam
Copy link
Contributor

marsam commented May 16, 2020

@bhipple do you think we could pin protobuf to protobuf3_11 and use protobuf3_8 just in the tensorflow expression?

@bhipple
Copy link
Contributor Author

bhipple commented May 18, 2020

Sounds reasonable to me, though TBH I'm not that close to the protobuf release stream -- I just see a lot of stuff requires protobuf 3.8+. It might be worth sending a PR and running a big nixpkgs-review on it to see if can just be upgraded.

@drewrisinger
Copy link
Contributor

drewrisinger commented May 18, 2020

@bhipple do you think we could pin protobuf to protobuf3_11 and use protobuf3_8 just in the tensorflow expression?

This could cause conflicts if a python environment requires both pythonPackages.protobuf and pythonPackages.tensorflow, depending on which version pythonPackages.protobuf uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.