Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hedgewars server fix haskell #87050

Merged
merged 2 commits into from May 8, 2020
Merged

Hedgewars server fix haskell #87050

merged 2 commits into from May 8, 2020

Conversation

@rardiol
Copy link
Contributor

rardiol commented May 6, 2020

Motivation for this change

gameServer/hedgewars-server.cabal requires network < 3.

hslogger currently uses network >3, so it conflicts and needs to be hidden when compiling.

I didn't manage to quote/escape "-Dhaskell_flags=-package network-2.6.3.1 -hide-package network-bsd" in a way that worked so used substituteInPlace. If anyone has a better fix please share.

maintainers @kragniz @fpletz

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
rardiol added 2 commits May 6, 2020
gameServer/hedgewars-server.cabal indicates network version needs
to be < 3.0.
@domenkozar
Copy link
Member

domenkozar commented May 6, 2020

@GrahamcOfBorg build hedgewars

@peti peti merged commit 01a1423 into NixOS:master May 8, 2020
16 checks passed
16 checks passed
hedgewars on aarch64-linux No attempt
Details
hedgewars on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae77b8f"; rev="ae77b8f42db25c783dc0434f20f8455e67cfcbc2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae77b8f"; rev="ae77b8f42db25c783dc0434f20f8455e67cfcbc2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae77b8f"; rev="ae77b8f42db25c783dc0434f20f8455e67cfcbc2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae77b8f"; rev="ae77b8f42db25c783dc0434f20f8455e67cfcbc2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae77b8f"; rev="ae77b8f42db25c783dc0434f20f8455e67cfcbc2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae77b8f"; rev="ae77b8f42db25c783dc0434f20f8455e67cfcbc2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ae77b8f"; rev="ae77b8f42db25c783dc0434f20f8455e67cfcbc2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
hedgewars on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.