Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.spyder_3: remove broken application #87062

Merged
merged 1 commit into from May 6, 2020

Conversation

@marcus7070
Copy link
Contributor

marcus7070 commented May 6, 2020

Motivation for this change

python3Packages.spyder_3 was failing due to incorrectly defined desktop item:
https://hydra.nixos.org/build/117762361

Things done

python3Packages.spyder_3 should only be used as a library (python3Packages.spyder gets made into an application), so I removed all the application stuff from it. This reduced closure size and fixed the build.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also tested cq-editor, which is the only attribute that uses spyder_3, and it works fine.

I should probably backport this to 20.03 as well.

Previously this had makeDesktopItem defined in it. Some recent tests
enabled for this option made it fail. It's no longer used as an
application (see the main spyder attribute for that), so all application
aspects have been removed.
@FRidh
Copy link
Member

FRidh commented May 6, 2020

Why shouldn't this be possible to use as application as well?

@marcus7070
Copy link
Contributor Author

marcus7070 commented May 6, 2020

@FRidh I didn't think anyone would use this v3.3.6 over the v4.1.2 we currently have in nixpkgs.

But if anyone would like to use it I'm happy to add it in. Do you want it added?

@FRidh
Copy link
Member

FRidh commented May 6, 2020

OK, I see that 4 works now as well (#83038). Why should it remain as library then?

Edit:

Nevermind, I see for cq-editor.

@marcus7070
Copy link
Contributor Author

marcus7070 commented May 6, 2020

Yeah, just cq-editor. I actually tried to modify the cq-editor code to work with spyder v4, but that task was too difficult for me.

@FRidh FRidh merged commit 026073e into NixOS:master May 6, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1ad34b0"; rev="1ad34b04777eae3cdd0c8b0c15f81f80a6dcf74d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1ad34b0"; rev="1ad34b04777eae3cdd0c8b0c15f81f80a6dcf74d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1ad34b0"; rev="1ad34b04777eae3cdd0c8b0c15f81f80a6dcf74d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1ad34b0"; rev="1ad34b04777eae3cdd0c8b0c15f81f80a6dcf74d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1ad34b0"; rev="1ad34b04777eae3cdd0c8b0c15f81f80a6dcf74d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1ad34b0"; rev="1ad34b04777eae3cdd0c8b0c15f81f80a6dcf74d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1ad34b0"; rev="1ad34b04777eae3cdd0c8b0c15f81f80a6dcf74d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@marcus7070 marcus7070 deleted the marcus7070:marcus7070/spyder-fix branch May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.