Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mu: allow configuring the BatchSize #87063

Merged
merged 1 commit into from May 7, 2020
Merged

Conversation

@peterhoeg
Copy link
Member

peterhoeg commented May 6, 2020

Motivation for this change

mu can in some scenarios use quite a bit of memory and no longer
supports a runtime parameter to adjust the memory use.

This change allows one to override the batch size if needed.

With few reverse dependencies, it shouldn't be an issue to compile this
locally but by default we don't change anything and stick to upstream.

ref: djcb/mu#1653

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@peterhoeg peterhoeg self-assigned this May 6, 2020
@peterhoeg peterhoeg force-pushed the peterhoeg:f/mu_batch_size branch from 438c22a to b96db45 May 6, 2020
@peterhoeg
Copy link
Member Author

peterhoeg commented May 6, 2020

@ryantm
ryantm approved these changes May 7, 2020
@ryantm ryantm merged commit a829af4 into NixOS:master May 7, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b96db45"; rev="b96db456f5f662ede17d4ec9301f2e174cde0876"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b96db45"; rev="b96db456f5f662ede17d4ec9301f2e174cde0876"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b96db45"; rev="b96db456f5f662ede17d4ec9301f2e174cde0876"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b96db45"; rev="b96db456f5f662ede17d4ec9301f2e174cde0876"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b96db45"; rev="b96db456f5f662ede17d4ec9301f2e174cde0876"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b96db45"; rev="b96db456f5f662ede17d4ec9301f2e174cde0876"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b96db45"; rev="b96db456f5f662ede17d4ec9301f2e174cde0876"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
mu, mu.passthru.tests on aarch64-linux Success
Details
mu, mu.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.