Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terragrunt: 0.23.2 -> 0.23.14 #87089

Merged
merged 1 commit into from May 7, 2020
Merged

terragrunt: 0.23.2 -> 0.23.14 #87089

merged 1 commit into from May 7, 2020

Conversation

@06kellyjac
Copy link
Contributor

06kellyjac commented May 6, 2020

Moved to use go modules build


This is my first real PR to nixpkgs, I welcome any and all criticism.
I removed the rm vendor line because it doesn't look relevant for go mod builds(?)

Let me know if there are extra steps I need to take

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ryantm
Copy link
Member

ryantm commented May 7, 2020

Thanks for your first PR welcome.

Looks like you can delete the deps.nix file too.

Copy link
Member

ryantm left a comment

Remove deps.nix file

@06kellyjac
Copy link
Contributor Author

06kellyjac commented May 7, 2020

Ah of course, I'll get on that

Moved to use go modules build
Deleted old deps.nix file used with dep
@06kellyjac 06kellyjac force-pushed the 06kellyjac:terragrunt branch from 5010368 to fc1b52c May 7, 2020
Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 87089 1

1 package built: - terragrunt

@jonringer jonringer merged commit cef39f9 into NixOS:master May 7, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc1b52c"; rev="fc1b52cd16d07c1e0fac3c15b5faee24ca6b1f3f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc1b52c"; rev="fc1b52cd16d07c1e0fac3c15b5faee24ca6b1f3f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc1b52c"; rev="fc1b52cd16d07c1e0fac3c15b5faee24ca6b1f3f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc1b52c"; rev="fc1b52cd16d07c1e0fac3c15b5faee24ca6b1f3f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc1b52c"; rev="fc1b52cd16d07c1e0fac3c15b5faee24ca6b1f3f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc1b52c"; rev="fc1b52cd16d07c1e0fac3c15b5faee24ca6b1f3f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="fc1b52c"; rev="fc1b52cd16d07c1e0fac3c15b5faee24ca6b1f3f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
terragrunt, terragrunt.passthru.tests on aarch64-linux Success
Details
terragrunt, terragrunt.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.