Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnutls: fix musl build #87111

Merged
merged 1 commit into from May 6, 2020
Merged

gnutls: fix musl build #87111

merged 1 commit into from May 6, 2020

Conversation

@B4dM4n
Copy link
Contributor

B4dM4n commented May 6, 2020

Motivation for this change

Fix pkgsMusl.gnutls build.

musl produces a different output than glibc during some tests, which let's them fail.

Using getpass(3) under musl when stdin is not a tty omits the prompt, which the certtool test expects to find.

See https://gitlab.com/gnutls/gnutls/-/issues/945

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

    No change for non-musl builds.

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

`musl` produces a different output than `glibc` during some tests, which
let's them fail.

Using `getpass(3)` under `musl` when `stdin` is not a tty omits the
prompt, which the `certtool` test expects to find.

See https://gitlab.com/gnutls/gnutls/-/issues/945
@Mic92 Mic92 merged commit d3a972d into NixOS:master May 6, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
gnutls, gnutls.passthru.tests on aarch64-linux Success
Details
gnutls, gnutls.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0665c87"; rev="0665c8776a5328f6cfe67ee554452dde5f4f9385"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0665c87"; rev="0665c8776a5328f6cfe67ee554452dde5f4f9385"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0665c87"; rev="0665c8776a5328f6cfe67ee554452dde5f4f9385"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0665c87"; rev="0665c8776a5328f6cfe67ee554452dde5f4f9385"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0665c87"; rev="0665c8776a5328f6cfe67ee554452dde5f4f9385"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0665c87"; rev="0665c8776a5328f6cfe67ee554452dde5f4f9385"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0665c87"; rev="0665c8776a5328f6cfe67ee554452dde5f4f9385"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@B4dM4n B4dM4n deleted the B4dM4n:gnutls-musl branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.