Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-utils: restore `beforePlugins` option #87127

Merged
merged 1 commit into from May 6, 2020
Merged

Conversation

@isaacwhanson
Copy link
Contributor

isaacwhanson commented May 6, 2020

some plugins require configuration before the plugin definition

Motivation for this change

my vim setup was broken when the beforePlugins option was removed, which allowed me to configure plugins that needed variables set before the plugin is loaded, like ALE.

Things done

restored the buildPlugins option, and put it to use in the rc file before the plugin definitions. tested that this worked on my system by building with nixos-rebuild switch -I nixpkgs=...

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
some plugins require configuration before their plugin definition
@jonringer jonringer requested review from evanjs and timokau May 6, 2020
@timokau timokau merged commit a12092b into NixOS:master May 6, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be1594b"; rev="be1594bf7a4eb458a2d81b6a679ddabce3dbc8d6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be1594b"; rev="be1594bf7a4eb458a2d81b6a679ddabce3dbc8d6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be1594b"; rev="be1594bf7a4eb458a2d81b6a679ddabce3dbc8d6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be1594b"; rev="be1594bf7a4eb458a2d81b6a679ddabce3dbc8d6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be1594b"; rev="be1594bf7a4eb458a2d81b6a679ddabce3dbc8d6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be1594b"; rev="be1594bf7a4eb458a2d81b6a679ddabce3dbc8d6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be1594b"; rev="be1594bf7a4eb458a2d81b6a679ddabce3dbc8d6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@isaacwhanson isaacwhanson deleted the isaacwhanson:fix/vim-beforePlugins branch May 7, 2020
@jonringer
Copy link
Contributor

jonringer commented May 7, 2020

Congrats @isaacwhanson on your first nixpkgs PR! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.