Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pantheon.elementary-icon-theme: Fix build with Inkscape 1.0 #87136

Closed
wants to merge 1 commit into from

Conversation

@jtojnar
Copy link
Contributor

jtojnar commented May 6, 2020

Use rsvg-convert to fix the Inkscape 1.0 incompatibility.

Cherry-picked from upstream PR: elementary/icons#888

Partial fix for #86930

Tested using the following fish invocations (there are minor rendering differences):

# Copy the data to working directories
set a /nix/store/2jgy87bnqw01l4jh94zx5g62xvd9zlnl-elementary-icon-theme-5.2.0
set b /nix/store/d37faf7xv98p21q7ahcgagiljqchp13k-elementary-icon-theme-5.2.0
set d share/icons/elementary/cursors
mkdir /tmp/{a,b}cur
cp $a/$d/* /tmp/acur
cp $b/$d/* /tmp/bcur

# Xcursor cannot be viewed directly, it seems
# Taken from https://unix.stackexchange.com/questions/241364/convert-xcursor-to-png
cd /tmp/acur
find . ! -name '*.*' -type f -exec xcur2png {} \;
cd /tmp/bcur
find . ! -name '*.*' -type f -exec xcur2png {} \;

# Compare
set a /tmp/acur
set b /tmp/bcur
mkdir /tmp/diffcur
set d .
for f in (cd $a/$d; fd png)
    echo Comparing $f
    compare -compose src $a/$d/$f $b/$d/$f /tmp/diffcur/$f
    # display /tmp/diffcur/$f
end

cc @worldofpeace

By not using Inkscape at all
@jtojnar
Copy link
Contributor Author

jtojnar commented Jun 7, 2020

Closing in favour of #89760

@jtojnar jtojnar closed this Jun 7, 2020
@jtojnar jtojnar deleted the jtojnar:elemiconink1 branch Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.