Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dnscrypt-proxy2: service restart on failure #87145

Merged
merged 1 commit into from May 22, 2020

Conversation

@snicket2100
Copy link
Contributor

snicket2100 commented May 6, 2020

Motivation for this change

it does happen that dnscrypt-proxy exits when it is unable to
synchronise its resolvers metadata on startup. this can happen due
to network connectivity issues for example. not restarting it automatically
means no dns resolution will work until a manual restart is performed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@snicket2100
Copy link
Contributor Author

snicket2100 commented May 6, 2020

I wasn't sure whether to use on-failure / on-abnormal/ on-abort instead of always. Would be happy to hear what the NixOS conventions are in this area.

@bjornfor
Copy link
Contributor

bjornfor commented May 21, 2020

I don't know of any convention. I think the Restart= value should be decided on per service. This PR seems like a strict improvement, so I approve it.

Copy link
Contributor

bjornfor left a comment

Nit: nixos commits should have nixos prefix: "nixos/dnscrypt-proxy2: ...".

it does happen that `dnscrypt-proxy` exit when it is unable to
synchronise its resolvers metadata on startup. this can happen due
to network connectivity issues for example. not restarting it automatically
means no dns resolution will work until a manual restart is performed.
@snicket2100 snicket2100 force-pushed the snicket2100:dnscrypt-proxy2-restart branch from 6dc604f to 1e6e419 May 21, 2020
@snicket2100 snicket2100 changed the title dnscrypt-proxy2: service restart on failure nixos/dnscrypt-proxy2: service restart on failure May 21, 2020
@snicket2100
Copy link
Contributor Author

snicket2100 commented May 21, 2020

Nit: nixos commits should have nixos prefix: "nixos/dnscrypt-proxy2: ...".

Fixed!

@bjornfor bjornfor merged commit 866b411 into NixOS:master May 22, 2020
14 checks passed
14 checks passed
editorconfig editorconfig
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e6e419"; rev="1e6e419c7a1636de410ffe31d6e02722bdf2488e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e6e419"; rev="1e6e419c7a1636de410ffe31d6e02722bdf2488e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e6e419"; rev="1e6e419c7a1636de410ffe31d6e02722bdf2488e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e6e419"; rev="1e6e419c7a1636de410ffe31d6e02722bdf2488e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e6e419"; rev="1e6e419c7a1636de410ffe31d6e02722bdf2488e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e6e419"; rev="1e6e419c7a1636de410ffe31d6e02722bdf2488e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1e6e419"; rev="1e6e419c7a1636de410ffe31d6e02722bdf2488e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.