Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdg-utils: Dont make lazy default on kde #87152

Closed

Conversation

@matthewbauer
Copy link
Member

matthewbauer commented May 6, 2020

This detection is broken as of kde5, so we need to disable it.

Upstream pr is: https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/25

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
matthewbauer added 2 commits May 6, 2020
This detection is broken as of kde5, so we need to disable it.

Upstream pr is: https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/25
common mistake
@ofborg ofborg bot requested a review from edolstra May 7, 2020
@matthewbauer matthewbauer changed the title Dont make lazy default on kde xdg-utils: Dont make lazy default on kde May 7, 2020
@drewrisinger
Copy link
Contributor

drewrisinger commented May 15, 2020

Could you just fetch this patch using fetchpatch? It looks like you can access the same content using https://gitlab.freedesktop.org/xdg/xdg-utils/-/merge_requests/25.patch (this could fail if you e.g. force-push that MR though...). Looks like this link could work. https://gitlab.freedesktop.org/xdg/xdg-utils/-/commit/6f2acdff42170204efc141179ef6b88cc70f41f6.patch

@drewrisinger
Copy link
Contributor

drewrisinger commented May 15, 2020

@GrahamcOfBorg build xdg_utils

@mjlbach mjlbach mentioned this pull request May 21, 2020
2 of 10 tasks complete
@matthewbauer
Copy link
Member Author

matthewbauer commented May 23, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.