Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safety-cli: init at 0.5.1 #87163

Merged
merged 3 commits into from May 8, 2020
Merged

Conversation

@thomasdesr
Copy link
Contributor

thomasdesr commented May 7, 2020

Motivation for this change

Makes it easier to check for known vulnerabilities in a projects' python dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [n/a] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

otherwise LGTM

pkgs/development/python-modules/dparse/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@thomasdesr thomasdesr force-pushed the thomasdesr:python-modules-safety branch 2 times, most recently from 88d7198 to d109a11 May 7, 2020
@thomasdesr thomasdesr requested a review from jonringer May 7, 2020
@thomasdesr
Copy link
Contributor Author

thomasdesr commented May 7, 2020

Thanks for the review, ptal :D

Copy link
Contributor

jonringer left a comment

otherwise LGTM, I know I said that already :)

@thomasdesr
Copy link
Contributor Author

thomasdesr commented May 7, 2020

Fixed!

ptal! :D

@thomasdesr thomasdesr requested a review from jonringer May 7, 2020
@thomasdesr thomasdesr force-pushed the thomasdesr:python-modules-safety branch from fdc6e26 to 7b9902a May 8, 2020
Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 87163 1

4 packages built: - python37Packages.dparse - safety-cli (python37Packages.safety) - python38Packages.dparse - python38Packages.safety

@jonringer jonringer merged commit 05bcfa1 into NixOS:master May 8, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b9902a"; rev="7b9902a4da689fb625d0dc8b67ec48f36a551e70"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b9902a"; rev="7b9902a4da689fb625d0dc8b67ec48f36a551e70"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b9902a"; rev="7b9902a4da689fb625d0dc8b67ec48f36a551e70"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b9902a"; rev="7b9902a4da689fb625d0dc8b67ec48f36a551e70"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b9902a"; rev="7b9902a4da689fb625d0dc8b67ec48f36a551e70"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b9902a"; rev="7b9902a4da689fb625d0dc8b67ec48f36a551e70"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b9902a"; rev="7b9902a4da689fb625d0dc8b67ec48f36a551e70"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
safety-cli, safety-cli.passthru.tests on aarch64-linux Success
Details
safety-cli, safety-cli.passthru.tests on x86_64-linux Success
Details
@thomasdesr thomasdesr deleted the thomasdesr:python-modules-safety branch May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.