Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libiberty: use pname #87164

Merged
merged 1 commit into from May 8, 2020
Merged

libiberty: use pname #87164

merged 1 commit into from May 8, 2020

Conversation

@sheenobu
Copy link
Contributor

sheenobu commented May 7, 2020

Motivation for this change

defining pname attribute

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

jonringer commented May 7, 2020

since this change causes over 500 rebuilds, do you mind targeting the staging branch

git rebase --onto=staging HEAD~1
git push .. ... --force

then change the base branch in the github PR from master -> staging

See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch

@Ericson2314 Ericson2314 changed the base branch from master to staging May 7, 2020
@Ericson2314 Ericson2314 changed the base branch from staging to master May 7, 2020
@Ericson2314
Copy link
Member

Ericson2314 commented May 7, 2020

Please rebase, looks good otherwise.

@FRidh FRidh changed the base branch from master to staging May 8, 2020
@FRidh FRidh added this to WIP in Staging via automation May 8, 2020
@FRidh FRidh moved this from WIP to Ready in Staging May 8, 2020
@FRidh FRidh merged commit ea56589 into NixOS:staging May 8, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db694c5"; rev="db694c579c49adbbbc8962c9e213e92e07b11ba2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db694c5"; rev="db694c579c49adbbbc8962c9e213e92e07b11ba2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db694c5"; rev="db694c579c49adbbbc8962c9e213e92e07b11ba2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db694c5"; rev="db694c579c49adbbbc8962c9e213e92e07b11ba2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db694c5"; rev="db694c579c49adbbbc8962c9e213e92e07b11ba2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db694c5"; rev="db694c579c49adbbbc8962c9e213e92e07b11ba2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="db694c5"; rev="db694c579c49adbbbc8962c9e213e92e07b11ba2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libiberty, libiberty.passthru.tests on aarch64-linux Success
Details
libiberty, libiberty.passthru.tests on x86_64-linux Success
Details
Staging automation moved this from Ready to Done May 8, 2020
@sheenobu
Copy link
Contributor Author

sheenobu commented May 16, 2020

missed the messages, thanks for moving to staging and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.