Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/postgresql: refactor enable option #87177

Merged
merged 1 commit into from May 7, 2020

Conversation

@joachimschmidt557
Copy link
Contributor

joachimschmidt557 commented May 7, 2020

More consistency with other modules (mkEnableOption)

Motivation for this change

Consistency with other NixOS modules (mkEnableOption)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Ensured that relevant documentation is up to date
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.
More consistency with other modules (mkEnableOption)
@Mic92
Copy link
Contributor

Mic92 commented May 7, 2020

Thanks!

@Mic92 Mic92 merged commit de37b23 into NixOS:master May 7, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Checking new out paths
Details
@joachimschmidt557 joachimschmidt557 deleted the joachimschmidt557:postgresql-enable-option branch May 7, 2020
@joachimschmidt557 joachimschmidt557 mentioned this pull request May 14, 2020
1 of 10 tasks complete
@joachimschmidt557 joachimschmidt557 mentioned this pull request May 27, 2020
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.