Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/{modules,tests}/teeworlds: init #87178

Merged
merged 1 commit into from Jun 12, 2020
Merged

Conversation

@hax404
Copy link
Contributor

hax404 commented May 7, 2020

Motivation for this change

add module and test for Teeworlds based on the OpenArena module and test

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@hax404 hax404 force-pushed the hax404:teeworlds-module-test branch 2 times, most recently from aec19ea to 9553c1d May 23, 2020
@hax404 hax404 force-pushed the hax404:teeworlds-module-test branch from 9553c1d to 4e47d7c Jun 6, 2020
@hax404
Copy link
Contributor Author

hax404 commented Jun 6, 2020

resolved race condition in the test and rebased on master

add module and test
@hax404 hax404 force-pushed the hax404:teeworlds-module-test branch from 4e47d7c to 6d1ca7d Jun 6, 2020
@hax404 hax404 requested a review from astsmtl Jun 12, 2020
@Mic92
Copy link
Contributor

Mic92 commented Jun 12, 2020

Will have a look.

server.sleep(10) # wait for a while to get a nice screenshot
client1.screenshot("screen_client1")

This comment has been minimized.

Copy link
@Mic92

Mic92 Jun 12, 2020

Contributor

I like this part.

@Mic92 Mic92 merged commit 8df5edc into NixOS:master Jun 12, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d1ca7d"; rev="6d1ca7db4abbc7c8851df8c89683763396aebb83"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d1ca7d"; rev="6d1ca7db4abbc7c8851df8c89683763396aebb83"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d1ca7d"; rev="6d1ca7db4abbc7c8851df8c89683763396aebb83"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d1ca7d"; rev="6d1ca7db4abbc7c8851df8c89683763396aebb83"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d1ca7d"; rev="6d1ca7db4abbc7c8851df8c89683763396aebb83"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d1ca7d"; rev="6d1ca7db4abbc7c8851df8c89683763396aebb83"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6d1ca7d"; rev="6d1ca7db4abbc7c8851df8c89683763396aebb83"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.