Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bashCompletion: speed-up test execution by using xdist #87189

Merged
merged 1 commit into from May 7, 2020

Conversation

@andir
Copy link
Member

andir commented May 7, 2020

Motivation for this change

Currently the tests take an eternity and are also sometimes flaky. By
following upstream in using xdist for parallel test execution we at
least get the feedback cycle down. On my machine that means instead of
running this for ~25min it runs in 1 minute and 10 seconds.

cc maintainers @peti @xfix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Currently the tests take an eternity and are also sometimes flaky. By
following upstream in using xdist for parallel test execution we at
least get the feedback cycle down. On my machine that means instead of
running this for ~25min it runs in 1 minute and 10 seconds.
@andir andir force-pushed the andir:bashcompletions branch from 781c1ca to a85b07c May 7, 2020
@andir andir changed the base branch from master to staging-18.03 May 7, 2020
@andir andir changed the base branch from staging-18.03 to staging May 7, 2020
@andir andir removed request for edwtjo, rycee, Ericson2314, edolstra, nbp and FRidh May 7, 2020
@andir
Copy link
Member Author

andir commented May 7, 2020

Oops, fat fingered the wrong staging branch.

@andir
Copy link
Member Author

andir commented May 7, 2020

@ofborg build bashCompletion

@Mic92 Mic92 merged commit af8d490 into NixOS:staging May 7, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
bashCompletion on aarch64-linux Success
Details
bashCompletion on x86_64-darwin Success
Details
bashCompletion on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85b07c"; rev="a85b07cbcb7a034bc07dda3642bc68fe621a63ec"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85b07c"; rev="a85b07cbcb7a034bc07dda3642bc68fe621a63ec"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85b07c"; rev="a85b07cbcb7a034bc07dda3642bc68fe621a63ec"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85b07c"; rev="a85b07cbcb7a034bc07dda3642bc68fe621a63ec"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85b07c"; rev="a85b07cbcb7a034bc07dda3642bc68fe621a63ec"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85b07c"; rev="a85b07cbcb7a034bc07dda3642bc68fe621a63ec"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a85b07c"; rev="a85b07cbcb7a034bc07dda3642bc68fe621a63ec"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.