Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nano: extend configuration-options #87192

Open
wants to merge 4 commits into
base: master
from
Open

Conversation

@sivizius
Copy link

@sivizius sivizius commented May 7, 2020

Motivation for this change

To have more options of /etc/nanorc implemented in pure nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions – afaik on all systems nano looks only at /etc/nanorc (or .nanorc, but that is something for home-manager), therefore, this should work on every system.
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) – there are no exutables involved
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This just modifies /etc/nanorc configuration and the generated nanorc-file looks ok and nano does not complain at start, so I guess it is fine.

@sivizius sivizius force-pushed the sivizius:master branch from 19f0147 to 11ad949 May 7, 2020
@sivizius sivizius changed the title Better nano-options nano: extend configuration-options May 7, 2020
@sivizius sivizius changed the title nano: extend configuration-options nixos/nano: extend configuration-options May 7, 2020
@sivizius sivizius force-pushed the sivizius:master branch from 11ad949 to adceadb May 7, 2020
More options for /etc/nanorc (all except syntax-highlighting).
@sivizius sivizius force-pushed the sivizius:master branch from adceadb to f20ebf0 May 7, 2020
sivizius added 3 commits May 7, 2020
nano2 was used while testing, but it should be nano.
›the nixos-rebuid‹ → ›nixos-rebuild‹
Corrected/updated some descriptions (typos, formarting, …).
@aanderse
Copy link
Contributor

@aanderse aanderse commented May 7, 2020

Hi @sivizius thanks for the contribution. This was a 42 line module... almost 1,000 now 😱 I feel like it would take me longer to understand how to write a configuration using this module than it would to use the nanorc option with man pages. Maybe an attribute set would be a nice compromise between simple module logic and a more structured configuration format 🤔

</opinion>

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.