Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write: init at 209 #87196

Closed
wants to merge 1 commit into from
Closed

write: init at 209 #87196

wants to merge 1 commit into from

Conversation

@olynch
Copy link
Contributor

olynch commented May 7, 2020

Motivation for this change

Added write, a word processor for handwriting

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Owen Lynch

stdenv.mkDerivation rec {
version = "209";
pname = "write-${version}";

This comment has been minimized.

Copy link
@ryantm

ryantm May 7, 2020

Member
Suggested change
pname = "write-${version}";
pname = "write";
pname = "write-${version}";

src = fetchurl {
url = "www.styluslabs.com/write/write209.tar.gz";

This comment has been minimized.

Copy link
@ryantm

ryantm May 7, 2020

Member
Suggested change
url = "www.styluslabs.com/write/write209.tar.gz";
url = "www.styluslabs.com/write/write${version}.tar.gz";
@i077
Copy link
Contributor

i077 commented May 7, 2020

Is this not the same as pkgs.write_stylus?

@ryantm
Copy link
Member

ryantm commented May 7, 2020

Closing because this is already packaged.

@ryantm ryantm closed this May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.