Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carthage: init at 0.34.0 #87199

Open
wants to merge 2 commits into
base: master
from
Open

carthage: init at 0.34.0 #87199

wants to merge 2 commits into from

Conversation

@vytis
Copy link

vytis commented May 7, 2020

Motivation for this change

Adding a package manager that is a popular tool when developing for Apple platforms.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor

jonringer commented May 7, 2020

This looks really fragile to maintain.

@vytis
Copy link
Author

vytis commented May 8, 2020

I based it on how Swift itself is built - https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/swift/default.nix.

However another approach would be to just allow Swift Package Manager to fetch all dependencies from git repositories as in original code before patching. This would simplify the derivation but we would lose caching that Nix provides in this case. I am not sure how big of a problem it is, maybe it makes more sense to keep the derivation simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.