Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcello: 0.9.2 -> 2.1.0 #87204

Merged
merged 2 commits into from May 12, 2020
Merged

libcello: 0.9.2 -> 2.1.0 #87204

merged 2 commits into from May 12, 2020

Conversation

@MostAwesomeDude
Copy link
Contributor

MostAwesomeDude commented May 7, 2020

Motivation for this change

libcello became much more usable with this major version bump several years ago. The library had a new release recently and that's what I've packaged here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Requested by ryantm. Thanks!

Co-authored-by: Ryan Mulligan <ryan@ryantm.com>
@ryantm ryantm merged commit 26a84c4 into NixOS:master May 12, 2020
@MostAwesomeDude MostAwesomeDude deleted the MostAwesomeDude:libcello branch May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.