Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libaec: init at 1.0.4; zopfli: include all headers #87205

Merged
merged 2 commits into from May 9, 2020

Conversation

@tbenst
Copy link
Contributor

tbenst commented May 7, 2020

Motivation for this change

Add/fix imagecodecs dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
tbenst added a commit to tbenst/poetry2nix that referenced this pull request May 7, 2020
Note that imagecodecs override depends on NixOS/nixpkgs#87205
@ofborg ofborg bot requested review from edef1c and bobvanderlinden May 7, 2020
@bobvanderlinden
Copy link
Contributor

bobvanderlinden commented May 8, 2020

I have very limited connectivity at the moment, so I won't be able to test this in the next few weeks.

adisbladis added a commit to tbenst/poetry2nix that referenced this pull request May 8, 2020
Note that imagecodecs override depends on NixOS/nixpkgs#87205
@adisbladis adisbladis force-pushed the tbenst:imagecodecs-pkgs branch from 84e9842 to e0258b8 May 8, 2020
@adisbladis
Copy link
Member

adisbladis commented May 8, 2020

@GrahamcOfBorg build libaec zopfli

@tbenst tbenst force-pushed the tbenst:imagecodecs-pkgs branch from e0258b8 to d35bcbb May 9, 2020
@adisbladis adisbladis merged commit a34175b into NixOS:master May 9, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d35bcbb"; rev="d35bcbb4ae0dea6a345af24e73024424f9f4cbed"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d35bcbb"; rev="d35bcbb4ae0dea6a345af24e73024424f9f4cbed"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d35bcbb"; rev="d35bcbb4ae0dea6a345af24e73024424f9f4cbed"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d35bcbb"; rev="d35bcbb4ae0dea6a345af24e73024424f9f4cbed"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d35bcbb"; rev="d35bcbb4ae0dea6a345af24e73024424f9f4cbed"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d35bcbb"; rev="d35bcbb4ae0dea6a345af24e73024424f9f4cbed"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d35bcbb"; rev="d35bcbb4ae0dea6a345af24e73024424f9f4cbed"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
libaec, libaec.passthru.tests, zopfli, zopfli.passthru.tests on aarch64-linux Success
Details
libaec, libaec.passthru.tests, zopfli, zopfli.passthru.tests on x86_64-linux Success
Details
adisbladis added a commit to tbenst/poetry2nix that referenced this pull request May 9, 2020
Note that imagecodecs override depends on NixOS/nixpkgs#87205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.