Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-miio: 0.4.8 -> 0.5.0.1 #87207

Merged
merged 1 commit into from May 7, 2020
Merged

python-miio: 0.4.8 -> 0.5.0.1 #87207

merged 1 commit into from May 7, 2020

Conversation

@flyfloh
Copy link
Contributor

flyfloh commented May 7, 2020

Motivation for this change

Update python-miio.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Florian
@flyfloh flyfloh requested review from FRidh and jonringer as code owners May 7, 2020
@ofborg ofborg bot added the 6.topic: python label May 7, 2020
Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 87207 1

2 packages built: - python37Packages.python-miio - python38Packages.python-miio

@jonringer jonringer merged commit 87927e9 into NixOS:master May 7, 2020
1 check was pending
1 check was pending
grahamcofborg-eval Checking new out paths
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.