Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isabelle: 2018 -> 2020 #87224

Open
wants to merge 4 commits into
base: master
from
Open

isabelle: 2018 -> 2020 #87224

wants to merge 4 commits into from

Conversation

@Sohalt
Copy link
Contributor

Sohalt commented May 7, 2020

Motivation for this change

Update to current version

cc @jwiegley

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Sohalt
Copy link
Contributor Author

Sohalt commented May 7, 2020

I couldn't test this on Darwin.

@yrashk
Copy link
Contributor

yrashk commented May 8, 2020

While we're at it, the license in this derivation states LGPL, the website says "Isabelle is distributed for free under a conglomerate of open-source licenses, but the main code-base is subject to BSD-style regulations". Should we change it to BSD?

Sohalt added 2 commits May 9, 2020
Fixup
Co-authored-by: puzzlewolf <23097564+puzzlewolf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.