Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitAndTools.git-fast-export: 190107 -> 200213, fix #87227

Open
wants to merge 2 commits into
base: master
from

Conversation

@risicle
Copy link
Contributor

risicle commented May 8, 2020

Motivation for this change

Turns out this was broken, probably by a mercurial bump to a py3k version. Fixed & bumped (still no py3k support in a released version though). Added an installCheckPhase so this doesn't happen again.

Would be good to get a working version of this out (maybe to stable?) what with the bitbucket mercurial shutdown approaching.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
risicle added 2 commits May 7, 2020
fixing involves providing it with mercurial_4 (and implicitly python27 -
current released fast-export doesn't support py3 yet) and adding git to
the wrapped PATH. this shouldn't be a runtime-resolved dependency.
this creates and converts a simple hg repository - should stop us
inadvertently breaking this package.
@risicle
Copy link
Contributor Author

risicle commented May 8, 2020

@GrahamcOfBorg build gitAndTools.git-fast-export

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.