Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.ipykernel: 5.1.3 -> 5.2.1 #87232

Closed
wants to merge 1 commit into from

Conversation

@marcus7070
Copy link
Contributor

marcus7070 commented May 8, 2020

Motivation for this change

Will resolve #87166

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This PR doesn't break anything new (on my machine at least). I think pythonPackages.qtconsole is broken and causing failed builds in a lot of packages that use ipykernel, but that's a problem for a different PR.

I see there is a lot of darwin stuff in this expression, I have no way of testing on darwin.

We should still bump pyzmq at some point, the ipykernel build still whinges about it.

@FRidh
Copy link
Member

FRidh commented May 8, 2020

@GrahamcOfBorg build pythonPackages3.ipykernel python38Packages.ipykernel

@FRidh
Copy link
Member

FRidh commented May 8, 2020

Duplicate of #87223

@FRidh FRidh marked this as a duplicate of #87223 May 8, 2020
@FRidh FRidh closed this May 8, 2020
@marcus7070 marcus7070 deleted the marcus7070:marcus7070/ipykernel-fix branch May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.